cloud-bulldozer / performance-dashboards

Performance dashboards from the Perf & Scale team
Apache License 2.0
17 stars 40 forks source link

Adding API-Performance-Overview Dashboard to grafonnet. #97

Closed smanda99 closed 8 months ago

smanda99 commented 10 months ago

Type of change

Description

Adding API-Performance Dashboard to grafonnet

Related Tickets & Documents

Checklist before requesting a review

Testing

smanda99 commented 8 months ago

Current Dashboard: Api-Performance dashboard

Jsonnet Coded Dashboard: Api-perfromance dashboard

smanda99 commented 8 months ago

http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/MpfMxQKIz/api-performance?orgId=1&refresh=30s this is previous dashboard.

http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/B6BGbwFSk/api-performance-dashboard?orgId=1&refresh=30s this one is new one

smanda99 commented 8 months ago

@vishnuchalla

old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/Xhe4kUpIz/api-performance?orgId=1&refresh=30s

new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/YfqVz8pSk/api-performance-dashboard?orgId=1&refresh=30s

vishnuchalla commented 8 months ago

label names and values doesn't seem to be matching exactly. Can you make sure that everything between the old and new dashboards is same.

Screenshot 2024-01-19 at 9 32 05 AM Screenshot 2024-01-19 at 9 32 06 AM
afcollins commented 8 months ago

Thanks for this PR @Manda-supraja26 ! I use this dashboard a lot and I would like the panel legends to have "Max" instead of "Last *". That's a change I make in my own dashboard copies because "Current" doesn't give me the information I want.

Also, if the Tooltips can "sort descending" that is also more helpful when there are usually large numbers of data series in one panel.

smanda99 commented 8 months ago

Thanks for this PR @Manda-supraja26 ! I use this dashboard a lot and I would like the panel legends to have "Max" instead of "Last *". That's a change I make in my own dashboard copies because "Current" doesn't give me the information I want.

Also, if the Tooltips can "sort descending" that is also more helpful when there are usually large numbers of data series in one panel.

Thanks for the review @afcollins. i will work on suggested changes.

smanda99 commented 8 months ago

@afcollins I have updated the dashboard. Please let me know if anything needs to be added. Dashboard links:

@vishnuchalla

old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/mniWpfpSk/api-performance?orgId=1&refresh=30s

new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/T6kZpftIk/api-performance-dashboard?orgId=1&refresh=30s

vishnuchalla commented 8 months ago

@afcollins I have updated the dashboard. Please let me know if anything needs to be added. Dashboard links:

@vishnuchalla old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/mniWpfpSk/api-performance?orgId=1&refresh=30s new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/T6kZpftIk/api-performance-dashboard?orgId=1&refresh=30s

@Manda-supraja26 I think its good to confirm that moving all the legends from "current" --> "max" is okay with all the users and is backward compatible.

smanda99 commented 8 months ago

@vishnuchalla old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/Fxd0tZhIz/api-performance?orgId=1&refresh=30s

new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/_8OAtZ2Ik/api-performance-dashboard?orgId=1&refresh=30s