search

cloud-bulldozer / scale-ci-pipeline

Automation to install, configure, scale test OpenShift and onboard new workloads
Apache License 2.0
17 stars 21 forks source link

add dynamic deploy path #213

Closed masco closed 3 years ago

masco commented 3 years ago

Description

Fixes

amitsagtani97 commented 3 years ago

hey @masco can we test these changes somewhere with post-install and config enabled?

masco commented 3 years ago

@amitsagtani97 tested https://jenkins.scalelab.redhat.com/job/ATS-SCALE-CI-OCP-OSP-DEPLOY/121/console

amitsagtani97 commented 3 years ago

we need to check it with OPENSHIFT_POST_INSTALL set to true here https://jenkins.scalelab.redhat.com/job/ATS-SCALE-CI-OCP-OSP-DEPLOY/121/parameters/ OPENSHIFT_POST_CONFIG does not use DYNAMIC_DEPLOY_PATH :)

masco commented 3 years ago

@amitsagtani97 we are not using post-install from this repo, we have our own script on jetpack.

we are setting the DYNAMIC_DEPLOY_PATH and the kubeconfig_path on the main script https://github.com/cloud-bulldozer/scale-ci-deploy/blob/master/OCP-4.X/install-on-osp.yml#L21-L35

this will be used for all the roles including the POST_CONFIG. that is why our job is failing to fetch/set the kubeconfig. so the test with the POST_CONFIG=true is enough for us to validate this PR.

Let me know if I am missing something.

amitsagtani97 commented 3 years ago

@amitsagtani97 we are not using post-install from this repo, we have our own script on jetpack.

we are setting the DYNAMIC_DEPLOY_PATH and the kubeconfig_path on the main script https://github.com/cloud-bulldozer/scale-ci-deploy/blob/master/OCP-4.X/install-on-osp.yml#L21-L35

this will be used for all the roles including the POST_CONFIG. that is why our job is failing to fetch/set the kubeconfig. so the test with the POST_CONFIG=true is enough for us to validate this PR.

Let me know if I am missing something.

@masco Makes sense. Looks good