Fix lint issues - Githubissues

cloud-ca / terraform-provider-cloudca

Terraform provider for cloud.ca

https://cloud.ca

MIT License

8 stars 10 forks source link

Fix lint issues #66

Closed khos2ow closed 5 years ago

khos2ow commented 5 years ago

Fixes lint issues:

(golint) comment on exported const
(errcheck) error return value not checked
(vet) result of fmt.Errorf call not used
(staticcheck) error strings should not be capitalized
(staticcheck) should replace loop
Remove obsolete linters: gosimple, unused

khos2ow commented 5 years ago

@pdube @franzpgarcia I agree with both of you and basically added _ = fmt.Errorf to make linter happy, and asides from Pat's suggestion we can also ignore them on lint level. Both approaches seem good to me. Do you have any preferences between the two?

pdube commented 5 years ago

I would prefer to not have any lint ignores

khos2ow commented 5 years ago

According to another provider as an example we might want to do something like this:

if err := d.Set("foo", foo); err != nil {
    return fmt.Errorf("Error reading Trigger: %s", err)
}

khos2ow commented 5 years ago

@pdube @franzpgarcia this should be good now.