Mc 16501 update tests hassan - Githubissues

cloud-ca / terraform-provider-cloudca

Terraform provider for cloud.ca

https://cloud.ca

MIT License

8 stars 10 forks source link

Mc 16501 update tests hassan #93

Closed HassanHaidar closed 2 years ago

HassanHaidar commented 2 years ago

Prerequisites

Put an x into the box(es) that apply:

[ ] This pull request fixes a bug.
[x] This pull request adds a feature.
[ ] This pull request enhances existing functionality.
[ ] This pull request introduces breaking change.

Description

Describe what this pull request achieves.

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into all boxes that apply:

Tests

[x] I have added tests to cover my changes.
[x] All tests pass when I run make test.

Documentation

[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

Code Style

[x] My code follows the code style of this project.
[ ] All checks pass when I run make checkfmt and make lint.

HassanHaidar commented 2 years ago

As I mentioned in #91 (comment) you don't necessarily need acceptance tests, they are very nice to have, for the providers to be healthy and up to date.

If you do want to proceed with acceptance tests, I'd suggest to revive #86 and finish up that PR and then rebase your PR here. Or you can completely ignore acceptance tests (i.e. any functions starts with TestAccXXX)

Thank you for your help! I will follow your suggestion 👍