search

cloud-custodian / cel-python

Pure Python implementation of the Common Expression Language
Apache License 2.0
99 stars 20 forks source link

Support for Python 3.6 and loose dependencies -> 0.1.2.1 version #32

Closed mcharrel closed 1 month ago

mcharrel commented 2 years ago

👋 I'd like to use this library for a program that runs on Python 3.6. Version 0.1.2 works but the fixed dependencies in the requirements are conflicting with my other dependencies.

Out of curiosity, what were the reasons (outside EOL in 2022) to exclude Python 3.6 starting from 0.1.3 ?

Would it be possible to publish a version (e.g 0.1.2.1) on Pypi with Python 3.6 and loose dependencies ? Compare changes

slott56 commented 2 years ago

Feel free to relax the requirements and make a PR with the change.

It would be best to pin the exact versions you need, rather than permit an open-ended requirement that could break in the future.

mcharrel commented 2 years ago

👋 coming back to this, it would require a branch starting from commit f6051df99010682ffb68d4d30bf8da832d210aa2 against which I would open a PR. 

git checkout f6051df99010682ffb68d4d30bf8da832d210aa2
git checkout -b <your-branch-name>
git push origin <your-branch-name>

Then I can open a PR against this branch, have it reviewed and merged.

After the merge, from this branch, a 0.1.2.1 release would need to be uploaded to pypi.

Does that sounds OK to you ?

slott56 commented 2 years ago

Sorry for not touching on this earlier: "...what were the reasons (outside EOL in 2022) to exclude Python 3.6 starting from 0.1.3 ?"

The reason was explicitly EOL. It's too difficult to support things past EOL.

slott56 commented 2 years ago

"After the merge, from this branch, a 0.1.2.1 release would need to be uploaded to pypi."

This release would have to be clearly marked as existing only to provide Python 3.6 support, with a caveat that Python 3.6 is past EOL. It is very likely to get orphaned.

Also. It seems like Commit 7170428795c0e1bce5ea7d287771059669159a84 might be more relevant, since it's the change to requirements.txt.

mcharrel commented 2 years ago

Commit 7170428 already mentions Python >= 3.7 in setup.py. You would branch of 7170428 and edit the setup.py file then ? Sounds good to me. Can you create the branch so I can open the PR ?

kapilt commented 2 years ago

3.6 is end of life dec 2021 not 2022.. aka a few weeks out.

slott56 commented 1 month ago

At this point, this seems to have been overtaken by events. (I have been bad at keeping up.)

At this point 3.8 is the oldest to be supported.