cloud-custodian / cel-python

Pure Python implementation of the Common Expression Language
Apache License 2.0
116 stars 22 forks source link

Remove defunct Makefile targets #65

Open KueZie opened 4 months ago

KueZie commented 4 months ago

Root Makefile contains defuct targets including but not limited to:

install:
  python3 -m venv .
  . bin/activate && pip install -r requirements-dev.txt

This functionality seems to have been ported to tox.ini and was never removed.

slott56 commented 4 months ago

After looking at the Makefile, my suggestion on deleting was a bad idea.

I don't think it should be deleted. I think it needs to be rewritten to use poetry properly instead of trivially deleted.