search

cloud-custodian / poetry-plugin-freeze

poetry plugin to freeze dependency versions in wheels
23 stars 4 forks source link

fix: ignore venv directory and non poetry pyproject.toml files (#14) #15

Open Toilal opened 10 months ago

Toilal commented 9 months ago

now two project_root methods which feels likely to cause confusion

Hi, the project_roots function has been extracted for it to be unitary tested. I'll fix the PR for linter to be happy.

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.41%. Comparing base (a525c9f) to head (0fa8bc8).

Files Patch % Lines
src/poetry_plugin_freeze/app.py 91.30% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15 +/- ## ========================================== - Coverage 97.08% 96.41% -0.68% ========================================== Files 1 1 Lines 206 223 +17 ========================================== + Hits 200 215 +15 - Misses 6 8 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Toilal commented 8 months ago

@ajkerrigan @kapilt i've just rebased this PR, could you have a look and tell if I need to change anything ?