search

cloud-erp-school-system / backend

GNU General Public License v3.0
0 stars 0 forks source link

#9 Remove Vaadin #10

Closed Aurrix closed 3 years ago

Aurrix commented 3 years ago

@patricksan Can you review this one?

Aurrix commented 3 years ago

I updated dependencies and switched back to java 11.

patricksan commented 3 years ago

@Aurrix There is just one remark. After that you can direct merge to master. One important action, let's merge using Squash and Merge.

Aurrix commented 3 years ago

@patricksan Do you know why the maven build fails with Travis? It builds ok locally. I am thinking maybe it's due to me switching to java 11?

patricksan commented 3 years ago

We can remove with the issue of Keycloack.

One thing we need to validate is the code format you are using. Are you using IntelliJ IDEA? Otherwise it shows that you changed the code but in reality was just formatting the file.

Related to the build fail, it is not just the jdk11 but also a profile from vaadin that was removed. I already fix in the master. So you can merge.

Thanks