search

cloud-erp-school-system / backend

GNU General Public License v3.0
0 stars 0 forks source link

Work in progress #23 #27

Closed captain0612 closed 3 years ago

captain0612 commented 3 years ago

Covered service layer as well as repository layer for unit test

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

patricksan commented 3 years ago

We could also have an integration test. That would start to test from the Controller. After we commit these classes I can do that.

patricksan commented 3 years ago

Hey @Aurrix , I did some comments in the PR, but it seems you merged with @captain0612 fix them. :-)

captain0612 commented 3 years ago

yea @patricksan we were trying to merge my changes and @Aurrix changes to resolve conflicts, anyway ill be be rising one more PR with the changes again :p