cloud-gov / caulking

Prevent leaks with gitleaks, and use tests to validate
Other
32 stars 11 forks source link

require explicit staging in recommended check-skipping function #1

Closed bengerman13 closed 4 years ago

bengerman13 commented 4 years ago

Changes proposed in this PR

I think this bash function would be better if it required explicit staging of files before force-committing, so users don't accidentally skip checks on more files than necessary

Security considerations

I think if users follow this recommendation, the proposed version is less likely to result in accidentally-committed secrets

pburkholder commented 4 years ago

Absolutely!