Fix IPv4 audit error - Githubissues

cloud-gov / caulking

Prevent leaks with gitleaks, and use tests to validate

Other

32 stars 11 forks source link

Fix IPv4 audit error #39

Closed pburkholder closed 3 years ago

pburkholder commented 3 years ago

Changes proposed in this pull request:

Fixed failing check for ipv4 by using \b on either side of the allowlist exception for ipv4-like strings that start with 0
Added a development test for Sauce access keys, no new patterns needed
README on how to roll back to older GitLeak (which turned out to be a red herring)

:tophat: tip to @jfredrickson5 for pairing on this.

security considerations

Enhancement with no downside. Content changes are patterns, tests ensure we're only reducing number of false positives.