search

cloud-gov / caulking

Prevent leaks with gitleaks, and use tests to validate
Other
32 stars 11 forks source link

V7 compatibilty changes, and new features #42

Closed pburkholder closed 3 years ago

pburkholder commented 3 years ago

Changes proposed in this pull request:

security considerations

None

pburkholder commented 3 years ago

@bengerman13 there's some ugliness around upgrading to 7.2.1 after our forced downgrade to 6.2.0, but this seems to work now more clean with 7.2.1 and uses the --unstaged switch so it should be much faster. Let me know.

bengerman13 commented 3 years ago

@pburkholder I checked this out locally, did make && make install and now it seems to not work at all: image

Did I install it wrong or ...?

pburkholder commented 3 years ago

Ah, I put the version check in make audit but not in the make default path, which is the same as make install.

Try make upgrade. If that works I'll do another commit to fix the install stanza.

Sorry you're hitting this. The brew team removed the switch feature in December, so it's harder now to upgrade cleanly after we did a forced downgrade to gitleaks 6.2.0.

bengerman13 commented 3 years ago

That seems to be working, and way faster as promised!