Only check for usernames in YML - Githubissues

cloud-gov / caulking

Prevent leaks with gitleaks, and use tests to validate

Other

32 stars 11 forks source link

Only check for usernames in YML #43

Closed pburkholder closed 3 years ago

pburkholder commented 3 years ago

Changes proposed in this pull request:

The existing Generic Username rule had gotten tripped up on the following Ruby code:

    user_count = input('admins').length + input('non-admins').length

so it seemed not to be a terribly useful rule. Updating to have an exception for Python, Go, Ruby, Terraform instead.

security considerations

Reduces false positives, which is good.