use SKIP=gitleaks flag instead of configs - Githubissues

cloud-gov / caulking

Prevent leaks with gitleaks, and use tests to validate

Other

32 stars 11 forks source link

use SKIP=gitleaks flag instead of configs #75

Closed pburkholder closed 2 years ago

pburkholder commented 2 years ago

Changes proposed in this pull request:

-

Reorg precommit into two functions, run_gitleaks and skip_gitleaks
Add logic to skip if either the config is off, or SKIP is set
Make it modestly annoying to SKIP

security considerations

This needs careful review to make sure we're not accidentally skipping gitleaks. But should improve the DX here.

pburkholder commented 2 years ago

Using prompt. See https://stackoverflow.com/questions/3417896/how-do-i-prompt-the-user-from-within-a-commit-msg-hook for why /dev/tty shows up.