cloud-gov / caulking

Prevent leaks with gitleaks, and use tests to validate
Other
32 stars 11 forks source link

Update git hook tests #89

Closed markdboyd closed 5 months ago

markdboyd commented 5 months ago

Changes proposed in this pull request:

Addresses #37

As noted in #37, it is possible to have local git hooks and gitleaks co-exist, but the tests run by make audit assume that is not possible. To fix this behavior, this PR:

Other unrelated fixes in the PR include:

security considerations

This PR should be correcting a misunderstanding of how git hooks work but not actually introducing any chance that the global git hook for gitleaks won't run. However, the changes should be audited carefully to avoid any possible regression

bengerman13 commented 5 months ago

thanks for cleaning up the README, too!