Add an sleep command for applications with multiple instances

cloud-gov / cf-blue-green

zero-downtime deployment for Cloud Foundry applications

Other

29 stars 12 forks source link

Add an sleep command for applications with multiple instances #34

Closed germanattanasio closed 6 years ago

germanattanasio commented 7 years ago

cf push will return as soon as some of the instances are running. If we don't wait until all of them start then we could execute curl --fail -I "https://${GREEN}.${DOMAIN}" and get a response different than 200.

This pull request adds an option to sleep for CF_SLEEP seconds (default to 5).

I'm testing it on one of my projects and It's working fine. Let me know if you don't like the variable name.

jmcarp commented 7 years ago

@germanattanasio: have you looked at alternative tools like https://github.com/contraband/autopilot/ ? This library is unmaintained.

germanattanasio commented 7 years ago

I found this tool to be more aligned to what I was trying to do. I want to use the manifest of the running app instead of the one in the source code.

jmcarp commented 7 years ago

We stopped developing this tool because we recommend not to use the manifest of the running app. YMMV 😄