search

cloud-gov / cf-cdn-service-broker

A Cloud Foundry service broker for CloudFront and Let's Encrypt
Other
10 stars 13 forks source link

Persist forwarded headers and cookies #113

Closed bengerman13 closed 4 years ago

bengerman13 commented 5 years ago

Currently, we don't persist the forwarded headers or forward cookies settings on a cdn-service instance. This is fine right now because we:

  1. don't document either of these features
  2. require users to set every parameter whenever they update any parameter

We need to start provisioning the cloudfront distribution asynchronously soon, which will require persisting all of these settings.

bengerman13 commented 5 years ago

I think #116 is the new best way out of our current bug, so this is no longer strictly necessary. It might be good to continue with this PR anyway, so we have these settings just in case we need them some time.

siennathesane commented 5 years ago

Rebase from master and it should resolve your conflicts.

bengerman13 commented 5 years ago

yeah - I also want to bring in the tag persistence from #115