Update cnames after getting certs

cloud-gov / cf-cdn-service-broker

A Cloud Foundry service broker for CloudFront and Let's Encrypt

Other

10 stars 13 forks source link

Update cnames after getting certs #116

Closed bengerman13 closed 5 years ago

bengerman13 commented 5 years ago

CloudFront recently changed their requirements so we now need to upload a certificate whenever setting a distribution cname. This PR delays setting the cname until we have a certificate.

This PR offers the following advantages over 18F/cf-cdn-service-broker#115:

no doc changes required
continued support for HTTP-01 cert challenges
no database schema changes

46bit commented 5 years ago

Thanks for this, 18F! We think updating is still broken. Will work on it this afternoon and get back to you with a patch. 🇺🇸🇬🇧✨