Update cnames after getting certs (for Update and Create)

cloud-gov / cf-cdn-service-broker

A Cloud Foundry service broker for CloudFront and Let's Encrypt

Other

10 stars 13 forks source link

Update cnames after getting certs (for Update and Create) #117

Closed tlwr closed 5 years ago

tlwr commented 5 years ago

Myself and @46bit took #116 and applied it to GDS's fork alphagov/paas-cdn-broker but @46bit found that Update was broken for the same reason as Create pre-fix.

This PR is the code-change in #116, plus an additional commit which uses the old domains when updating Cloudfront in Update, and relies on deployCertificate to do the actual certificate and CNAME changes.

Please let us know if we need to sign a CLA, alternatively feel free to ignore/close this PR.

Context

46bit commented 5 years ago

🎉

@bengerman13 We also have a commit to delete some unused code that you might like https://github.com/alphagov/paas-cdn-broker/pull/13/commits/ce0033cee064cb082771e82c95d447308e11ff08