Closed siennathesane closed 5 years ago
@jontours @bengerman13 I finished adding the logging instrumentation to the route manager (core logic), so it's ready for review now.
✗ git status; git --no-pager log -n1 --oneline; go test -v ./...
c7b08e1 (HEAD -> logging-fix, origin/logging-fix) finished adding logging instrumentation.
=== RUN TestBind
--- PASS: TestBind (0.00s)
=== RUN TestUnbind
--- PASS: TestUnbind (0.00s)
=== RUN TestLastOperation
=== RUN TestLastOperation/TestLastOperationDeprovisioning
=== RUN TestLastOperation/TestLastOperationMissing
=== RUN TestLastOperation/TestLastOperationProvisioning
=== RUN TestLastOperation/TestLastOperationSucceeded
--- PASS: TestLastOperation (0.00s)
--- PASS: TestLastOperation/TestLastOperationDeprovisioning (0.00s)
--- PASS: TestLastOperation/TestLastOperationMissing (0.00s)
--- PASS: TestLastOperation/TestLastOperationProvisioning (0.00s)
--- PASS: TestLastOperation/TestLastOperationSucceeded (0.00s)
=== RUN TestProvisioning
=== RUN TestProvisioning/TestDomainNotExists
=== RUN TestProvisioning/TestForwardedHeadersDuplicates
=== RUN TestProvisioning/TestForwardedHeadersMoreThanTen
=== RUN TestProvisioning/TestForwardedHeadersWhitelistAndWildcard
=== RUN TestProvisioning/TestInstanceExists
=== RUN TestProvisioning/TestMultipleDomainsMoreThanOneNotExists
=== RUN TestProvisioning/TestMultipleDomainsOneNotExists
=== RUN TestProvisioning/TestSuccess
=== RUN TestProvisioning/TestSuccessCustomOrigin
=== RUN TestProvisioning/TestSuccessForwardedSingleHeader
=== RUN TestProvisioning/TestSuccessForwardingDuplicatedHostHeader
=== RUN TestProvisioning/TestSuccessForwardingWildcardHeader
=== RUN TestProvisioning/TestSuccessNineForwardedHeaders
=== RUN TestProvisioning/TestSync
=== RUN TestProvisioning/TestWithoutDetails
=== RUN TestProvisioning/TestWithoutOptions
--- PASS: TestProvisioning (0.00s)
--- PASS: TestProvisioning/TestDomainNotExists (0.00s)
--- PASS: TestProvisioning/TestForwardedHeadersDuplicates (0.00s)
--- PASS: TestProvisioning/TestForwardedHeadersMoreThanTen (0.00s)
--- PASS: TestProvisioning/TestForwardedHeadersWhitelistAndWildcard (0.00s)
--- PASS: TestProvisioning/TestInstanceExists (0.00s)
--- PASS: TestProvisioning/TestMultipleDomainsMoreThanOneNotExists (0.00s)
--- PASS: TestProvisioning/TestMultipleDomainsOneNotExists (0.00s)
--- PASS: TestProvisioning/TestSuccess (0.00s)
--- PASS: TestProvisioning/TestSuccessCustomOrigin (0.00s)
--- PASS: TestProvisioning/TestSuccessForwardedSingleHeader (0.00s)
--- PASS: TestProvisioning/TestSuccessForwardingDuplicatedHostHeader (0.00s)
--- PASS: TestProvisioning/TestSuccessForwardingWildcardHeader (0.00s)
--- PASS: TestProvisioning/TestSuccessNineForwardedHeaders (0.00s)
--- PASS: TestProvisioning/TestSync (0.00s)
--- PASS: TestProvisioning/TestWithoutDetails (0.00s)
--- PASS: TestProvisioning/TestWithoutOptions (0.00s)
=== RUN TestUpdating
=== RUN TestUpdating/TestDomainNotExists
=== RUN TestUpdating/TestForwardedHeadersMoreThanTen
=== RUN TestUpdating/TestForwardedHeadersWhitelistAndWildcard
=== RUN TestUpdating/TestSuccessForwardedSingleHeader
=== RUN TestUpdating/TestSuccessForwardingDuplicatedHostHeader
=== RUN TestUpdating/TestSuccessForwardingWildcardHeader
=== RUN TestUpdating/TestSuccessNineForwardedHeaders
=== RUN TestUpdating/TestUpdateSuccess
=== RUN TestUpdating/TestUpdateSuccessOnlyDomain
=== RUN TestUpdating/TestUpdateSuccessOnlyOrigin
=== RUN TestUpdating/TestUpdateWithoutOptions
--- PASS: TestUpdating (0.00s)
--- PASS: TestUpdating/TestDomainNotExists (0.00s)
--- PASS: TestUpdating/TestForwardedHeadersMoreThanTen (0.00s)
--- PASS: TestUpdating/TestForwardedHeadersWhitelistAndWildcard (0.00s)
--- PASS: TestUpdating/TestSuccessForwardedSingleHeader (0.00s)
--- PASS: TestUpdating/TestSuccessForwardingDuplicatedHostHeader (0.00s)
--- PASS: TestUpdating/TestSuccessForwardingWildcardHeader (0.00s)
--- PASS: TestUpdating/TestSuccessNineForwardedHeaders (0.00s)
--- PASS: TestUpdating/TestUpdateSuccess (0.00s)
--- PASS: TestUpdating/TestUpdateSuccessOnlyDomain (0.00s)
--- PASS: TestUpdating/TestUpdateSuccessOnlyOrigin (0.00s)
--- PASS: TestUpdating/TestUpdateWithoutOptions (0.00s)
PASS
ok github.com/18F/cf-cdn-service-broker/broker 0.433s
? github.com/18F/cf-cdn-service-broker/cf [no test files]
? github.com/18F/cf-cdn-service-broker/cf/mocks [no test files]
=== RUN TestHTTPHandler
--- PASS: TestHTTPHandler (0.00s)
PASS
ok github.com/18F/cf-cdn-service-broker/cmd/cdn-broker 0.519s
? github.com/18F/cf-cdn-service-broker/cmd/cdn-cron [no test files]
? github.com/18F/cf-cdn-service-broker/config [no test files]
? github.com/18F/cf-cdn-service-broker/healthchecks [no test files]
=== RUN TestDeleteOrphanedCerts
{"timestamp":"1559575953.093585968","source":"cdn-cron-test","message":"cdn-cron-test.cleaning-orphaned-certificate","log_level":1,"data":{"cert":{"Arn":"some-orphaned-cert","Expiration":null,"Path":null,"ServerCertificateId":"this-cert-should-be-deleted","ServerCertificateName":"some-orphaned-cert","UploadDate":"2019-06-01T09:32:33.093454-06:00"}}}
{"timestamp":"1559575953.093851805","source":"cdn-cron-test","message":"cdn-cron-test.cleaning-orphaned-certificate","log_level":1,"data":{"cert":{"Arn":"some-other-orphaned-cert","Expiration":null,"Path":null,"ServerCertificateId":"this-cert-should-also-be-deleted","ServerCertificateName":"some-other-orphaned-cert","UploadDate":"2019-06-01T09:32:33.093454-06:00"}}}
--- PASS: TestDeleteOrphanedCerts (0.00s)
mock.go:415: PASS: DeleteCertificate(string)
mock.go:415: PASS: DeleteCertificate(string)
PASS
ok github.com/18F/cf-cdn-service-broker/models 0.562s
? github.com/18F/cf-cdn-service-broker/models/mocks [no test files]
=== RUN TestHeaders
=== RUN TestHeaders/TestAdd
=== RUN TestHeaders/TestContains
=== RUN TestHeaders/TestStrings
--- PASS: TestHeaders (0.00s)
--- PASS: TestHeaders/TestAdd (0.00s)
--- PASS: TestHeaders/TestContains (0.00s)
--- PASS: TestHeaders/TestStrings (0.00s)
PASS
ok github.com/18F/cf-cdn-service-broker/utils (cached)
just adding more logging context to assist with debugging.
Signed-off-by: Mike Lloyd mike.lloyd@gsa.gov