search

cloud-gov / cf-cdn-service-broker

A Cloud Foundry service broker for CloudFront and Let's Encrypt
Other
10 stars 13 forks source link

[WIP] Support Multiple domains #21

Closed dlapiduz closed 8 years ago

dlapiduz commented 8 years ago

The idea here is to allow users to pass a comma delimited string rather than just one domain.

dlapiduz commented 8 years ago

It resolves #20 20

dlapiduz commented 8 years ago

/cc @jmcarp

jmcarp commented 8 years ago

Looks good. I was thinking of accepting domains as an actual json array, but this is simpler, so 👍. Can you add a multi-domain example to the readme also?

dlapiduz commented 8 years ago

I know json array makes sense but this was simpler :).

Added the instructions though.

dlapiduz commented 8 years ago

ok, this took actual work... thanks @jmcarp