refactor tests - Githubissues

cloud-gov / cf-cdn-service-broker

A Cloud Foundry service broker for CloudFront and Let's Encrypt

Other

10 stars 13 forks source link

refactor tests #44

Closed afeld closed 7 years ago

afeld commented 7 years ago

Pairing with @jcscottiii.

Split the broker tests into separate files by method
Switched to using true mocks rather than a hand-rolled equivalent
Switched to using Glide for package management (we were having issues trying to add dependencies with Godep)

jcscottiii commented 7 years ago

Let's wait on this. Trying deploying manually and it fails. Godep had some magic that built everything vs glide variant didn't deploy successfully.

jcscottiii commented 7 years ago

We fixed this via https://github.com/18F/cf-cdn-service-broker/pull/44/commits/5d2bb28892c3f5e24619ee372c9ded9fcee74441