search

cloud-gov / cf-cdn-service-broker

A Cloud Foundry service broker for CloudFront and Let's Encrypt
Other
10 stars 13 forks source link

log provisioning/deprovisioning errors #48

Closed cnelson closed 7 years ago

jmcarp commented 7 years ago

Since we're already using lager for logging (since it's used in brokerapi), wdyt about adding logger lager.Logger to the CdnServiceBroker struct and using that to add the error log?

cnelson commented 7 years ago

I haven't used lager before, does that look right? 👇

jmcarp commented 7 years ago

LGTM, I think we just need to pass the logger when instantiating the broker in https://github.com/18F/cf-cdn-service-broker/blob/master/cmd/cdn-broker/main.go#L47-L49.

jmcarp commented 7 years ago

Tests passing locally, LGTM.