Prevent failed challenges from creating orphaned distributions.

cloud-gov / cf-cdn-service-broker

A Cloud Foundry service broker for CloudFront and Let's Encrypt

Other

10 stars 13 forks source link

Prevent failed challenges from creating orphaned distributions. #83

Closed wjwoodson closed 7 years ago

wjwoodson commented 7 years ago

Prior to this change, we create cloudfront distributions before acme challenges. If creating acme challenges fails, we're left with an orphaned cloudfront distribution that the broker isn't aware of. This patch gets the acme challenges first to avoid this confusing state.

cnelson commented 7 years ago

Seems reasonable to me, WDYT @jmcarp?

@wjwoodson Should fix the gofmt stuff the lintering is complaining about :)