search

cloud-gov / cg-dashboard

Unarchived due to stratos bug in user management: https://github.com/cloudfoundry/stratos/issues/4103
Other
30 stars 18 forks source link

Address codeclimate "security" issues #1298

Closed pburkholder closed 6 years ago

pburkholder commented 6 years ago

Codeclimate uses nodesecurity for javascript checks. This turns up findings for for outdated dependencies that have known issues.

This PR introduces the .nsprc file for the exclusions which are currently tied to development dependencies. The commenting feature for .nsprc isn't working yet, so I made up a comments data section.

In addition to updating package.json, I've also moved the eslint- and karma-related packages into the dev section.

pburkholder commented 6 years ago

Turns out, moving karma and eslint to the dev section got all the codeclimate checks to pass.

pburkholder commented 6 years ago

Thanks - I'm going to hold off merging until I can work on the #1252 PR, since I don't want to frustrate the latest rebase there.