search

cloud-gov / cg-migrate-db

Export database from cloud.gov app
Other
4 stars 6 forks source link

Embed PSQL and MYSQL clients in plugin & Use python buildpack #14

Closed jcscottiii closed 7 years ago

jcscottiii commented 7 years ago

The previous iteration of this plugin used a custom buildpack. However, it became brittle and it made the program to actually have to install the aws (and not the buildpack). Instead, we will use the native python buildpack and use pip to install any requirements that were broken in the last iteration of the plugin. The one requirement that failed to install manually was awscli. Instead, we now have a requirements.txt to specify the need for it.

In addition, the previous buildpack had the mysql and psql tools. Instead of using that buildpack, we will embed the tools in the plugin itself and will deploy with the export/import app bits

jcscottiii commented 7 years ago

cc: @afeld @ccostino

jcscottiii commented 7 years ago

hmm. i dont think @ccostino will have perms to merge this. only the cloud-gov team has perms for this repo. can we give him write perms? not sure if that has any implications. @brittag would know the rules. Britta, help?

ccostino commented 7 years ago

That is correct sir, I can only go as far as approving changes. I'm happy to defer to others, especially if there are concerns/barriers with giving others write perms not on the team. :-)

brittag commented 7 years ago

Ah yeah, merging for cloud.gov repos has to be done by a cloud.gov team member (who has been assigned to the cloud.gov team, gone through our cloud.gov-specific onboarding process, etc.), since we have relatively strict requirements for code control due to our FedRAMP requirements. Thank you for asking!

ccostino commented 7 years ago

No worries at all, I had figured as much. :-) Thank you, @brittag!

jcscottiii commented 7 years ago

thanks @brittag !