cloud-gov / cg-site

The cloud.gov website
https://cloud.gov
Other
59 stars 121 forks source link

Anchor links no longer appearing in docs #235

Closed afeld closed 7 years ago

afeld commented 8 years ago

What we're after:

Notes:

Hovering over a heading on any particular page isn't appearing...not sure if it's a CSS conflict or something? Not immediately obvious what the issue is.

/cc @msecret

Acceptance criteria:

msecret commented 8 years ago

@afeld do we know what version(or commit hash) of the repo is currently on production? I know at some point we were not seeing most recent changes deployed, and that might point to the issue.

afeld commented 8 years ago

Wercker indicates that it's da8fe4940cac1e0e53534a864f24e4134d1511c5, deployed yesterday.

https://app.wercker.com/#applications/55036dfb210ef9cf6a005391/tab/deployment/

msecret commented 8 years ago

Looks like the JS is on the page:

  // AnchorJS
  anchors.options.visible = 'touch';
  anchors.add('.content h2,.content h3,.content h4,.content h5');
msecret commented 8 years ago

It could be that the anchorjs icons aren't loading correctly. I can't find them in the resources/network panel.

suprenant commented 7 years ago

@thisisdano to take a quicker look to see to if he can reproduce this. If not, he'll ask for some help.

suprenant commented 7 years ago

screen shot 2016-12-06 at 12 25 15 pm

^production

afeld commented 7 years ago

Seems to have been fixed!

thisisdano commented 7 years ago

This seems to be a new issue now. Anchor links are no longer appearing at all in my local instance (but they are on cloud.gov).

Locally, the heds are missing the <a class="anchorjs-link ">

@msecret @line47 can you reproduce?

cloud.gov screen shot 2016-12-06 at 11 25 01 am

local screen shot 2016-12-06 at 11 25 09 am

thisisdano commented 7 years ago

See above ^^^

I see a new anchor link issue now... May as well piggyback on this issue since it's on our radar.

line47 commented 7 years ago

I just got latest on this project and am seeing anchor links at H2 and H3 headers.

Screenshot

screen shot 2016-12-07 at 10 28 26 am
thisisdano commented 7 years ago

OK. huh. Cos not only do you see the links, but the spacing seems better than mine. (See space between the ol and the h2) — wtf?

I seem to be on the latest master for both cg-site and cg-style...


screen shot 2016-12-07 at 8 01 10 am
suprenant commented 7 years ago

@adborden to lend a hand here

adborden commented 7 years ago

We worked out the issue with @thisisdano 's setup and think this issue is fixed. @thisisdano do you want me to open a separate issue for the header spacing since that seems to be a valid bug.