search

cloud-gov / cg-uaa

DEPRECATED / DO NOT USE. This repo contains an old version of UAA with known security vulnerabilities. Use the upstream version
Apache License 2.0
2 stars 5 forks source link

Bring in upstream changes into master #39

Closed rogeruiz closed 7 years ago

rogeruiz commented 7 years ago

Pairing with @rememberlenny

⚠️ 🚧 #40 needs to be merged in to this branch before merging this into master 🚧 ⚠️

rogeruiz commented 7 years ago

Looks like we gotta fix some tests @rememberlenny. Gonna look into this locally. 😢 🗞

rogeruiz commented 7 years ago

Blocked because tests are failing and we'll need to update the submodules in our CF boshrelease as well.

rogeruiz commented 7 years ago

👍 tests are mostly passing. Turns out it was a node library causing the error :trollface:

It was actually the {cg->govcloud} path change not being reflected in the tests 👼

rogeruiz commented 7 years ago

One of the LDAP tests failed, but wahtvere. I think we can still safely merge this in the morning. The rest of them passed.

ERROR: failed to upload: /home/travis/build/cloudfoundry/uaa/uaa/build/reports/tests/org.cloudfoundry.identity.uaa.integration.feature.OIDCLoginIT/successfulLoginWithOIDC_and_SAML_Provider.png
  err: The AWS Access Key Id you provided does not exist in our records.