Closed echappen closed 1 week ago
@beepdotgov Question I forgot to ask in feasibility review: allocated memory can return null (infinite) from the API. When that happens, what should be shown? (@hursey013 I'm assuming if it can return null, it will, unless Cloud.gov somehow doesn't allow this.)
@echappen Oh, great catch — thanks, Eleni.
I’d like to hear what @hursey013 says on the business rules front, because I could see two possible scenarios:
Brian, let me know what you think? I can mock up whichever option feels right for Cloud. (Or both options, if need be!)
Interesting! Given the way the IAAs are written I believe every customer should have an assigned memory quota in production, but I could see perhaps some internal facing cloud.gov orgs or experimental orgs in dev having a null value. I'd say in those cases we could either suppress the progress bar, or better yet could we illustrate that there is no limit set with a ∞
symbol on the upper limit so it's clear there is no limit?
Thanks, @hursey013! I did a quick pass on what this could look like:
How’s that feel to you?
I think this looks great, thanks @beepdotgov!
Wonderful, thanks @hursey013!
@echappen, I’ve updated Figma showing a card with this state, but let me know if you need anything else from me!
Looks great @beepdotgov, thank you both! I'll start implementing this.
Sorry to bring this up again: "24MB allocated; no upper limit" - the 24MB figure here is coming from the usage summary endpoint and represents actual usage. May I change "allocated" to "used" here? (just for instances with no upper limit)
Sorry to bring this up again: "24MB allocated; no upper limit" - the 24MB figure here is coming from the usage summary endpoint and represents actual usage. May I change "allocated" to "used" here? (just for instances with no upper limit)
Yes, that makes sense to me @echappen!
Ach yes, sorry — after our memory conversation last week, I think I forgot to update that. (The jokes, they write themselves.)
I’ll update Figma as well, to make sure those cards say “used” rather than “allocated”. [Edit: done.]
Similar design elements to #514 so coordinate with @cannandev on shared components
Figma widescreen Figma small screen
Acceptance Criteria