cloud-gov / compliance

Compliance automation for cloud.gov
Other
36 stars 22 forks source link

Add Kwadwo to IAM audit file #227

Closed ccostino closed 3 years ago

ccostino commented 3 years ago

This changset adds @kwadwok15's account to our IAM audit file.

Changes proposed in this pull request:

Security considerations

pburkholder commented 3 years ago

So running this:

aws-vault exec cg-govcloud -- bin/inspec exec ./aws-mfa/ -t aws:// --input-file inputs.yml --silence-deprecations=aws

Results in:

image

So we can do one of:

ccostino commented 3 years ago

I updated the test, @pburkholder, it was the quicker and easier option. I thought about modifying it to reference the input file itself and wasn't sure how to proceed - I'd have to spend some time understanding how InSpec parses the file and makes its info available in the tests) - however, it makes me wonder if this test counting users is useful. The InSpec process will just take all records listed in the file, will it not? Is there a situation where it might not audit/test everything put in the input file?

If there is, then I wonder if it's wise to put the count in the input file itself vs. having that be defined separately as it is now, to ensure the audit it done correctly. I may be overthinking it, but I just want to make sure that 1) we have a useful test, and 2) the audit is done correctly.

pburkholder commented 3 years ago

I'm going to merge this and fix the number of users separately.

ccostino commented 3 years ago

D'oh, sorry! I forgot about that again when I removed John.