Cleanup stale keys code and emit warning and violation dates for each stale key - Githubissues

cloud-gov / deploy-prometheus

Other

4 stars 3 forks source link

Cleanup stale keys code and emit warning and violation dates for each stale key #222

Closed rcgottlieb closed 5 months ago

rcgottlieb commented 7 months ago

In order to [reason/outcome/goal], [someone or "we"] want [a specific change in product implementation/behavior]

Acceptance Criteria

[ ] GIVEN an operator is reviewing alerts in alertmanager\ THEN any alert for stale keys will now display both the warning and violation dates

Security considerations

None, mostly code cleanup and addition of two new fields

Implementation sketch

[links to background notes, sketches, and/or relevant documentation

[x] Go through the code and update/modify where needed
[x] Update the database to include two new columns for Event: warning_delta and violation_delta
[x] Update code that searches for stale keys to include warning_delta and violation_delta in the results
[x] Update the code that sends the results to the gateway to include warning and violation dates

rcgottlieb commented 5 months ago

This ticket is done but not deployed. Instead I created another ticket for an overhaul to this to remove the database if at all possible. Here is the ticket: https://github.com/cloud-gov/product/issues/3015

That ticket will use the current code base for this ticket as a starting point. The code is tagged in order to use this commit later if needed.