cloud-gov / external-domain-broker

Cloud Foundry service broker to manage Cloud Front, ALBs and Let's Encrypt
Other
3 stars 2 forks source link

Add initial changes for CDN with dedicated WAF plan #333

Closed markdboyd closed 1 month ago

markdboyd commented 1 month ago

Related to https://github.com/cloud-gov/private/issues/1098

Changes proposed in this pull request:

Things to check

Security considerations

There should not be any code changes impacting security. However, the ability to provision CDN plans with dedicated WAF web ACLs should be an improvement for security

bengerman13 commented 1 month ago

added some comments about type hints, and I think they're a little off in some other places - probably worth running mypy against this codebase in the near-ish future since it's getting a bit big and complex, but I don't think it's a blocker for this PR