Closed markdboyd closed 1 month ago
added some comments about type hints, and I think they're a little off in some other places - probably worth running mypy
against this codebase in the near-ish future since it's getting a bit big and complex, but I don't think it's a blocker for this PR
Related to https://github.com/cloud-gov/private/issues/1098
Changes proposed in this pull request:
tests/integration/test_cdn_provision_common_checks.py
tests/integration/test_cdn_update_common_checks.py
tests/lib/provision.py
- shared helpers for all provision teststests/lib/update.py
- shared helpers for all update teststests/lib/alb/provision.py
- shared helpers for ALB provision teststests/lib/alb/update.py
- shared helpers for ALB update teststests/lib/cdn/provision.py
- shared helpers for CDN provision teststests/lib/cdn/update.py
- shared helpers for CDN update testsdocker/docker-compose.yml
to allow for easier local testing and running unit tests via VScodeThings to check
INFO
and debugging statements are written withlog.debug
or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
There should not be any code changes impacting security. However, the ability to provision CDN plans with dedicated WAF web ACLs should be an improvement for security