Fix listener ARNs input from config to remove_duplicate_alb_certs. config.ALB_LISTENER_ARNS and config.DEDICATED_ALB_LISTENER_ARNS are already lists, so surrounding them with [] makes them a list of lists, which causes errors when passing these arguments as a ListenerArn to boto3 commands like describe_listener_certificates
Upgrade integration tests to test for the above scenario to avoid regression
Things to check
For any logging statements, is there any chance that they could be logging sensitive data?
Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.
Changes proposed in this pull request:
remove_duplicate_alb_certs
.config.ALB_LISTENER_ARNS
andconfig.DEDICATED_ALB_LISTENER_ARNS
are already lists, so surrounding them with[]
makes them a list of lists, which causes errors when passing these arguments as aListenerArn
to boto3 commands likedescribe_listener_certificates
Things to check
INFO
and debugging statements are written withlog.debug
or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
None, just fixing bug in behavior