Add deprovision pipeline and API handling for dedicated WAF CDN plan
Add integration tests for deprovisioning dedicated WAF CDN plan instances
Move common deprovision tests to tests/integration/test_deprovision_common_checks.py using pytest parameterization
Moved shared deprovision test helpers to tests/lib/cdn/deprovision.py
Things to check
For any logging statements, is there any chance that they could be logging sensitive data?
Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.
Security considerations
There should be no security considerations to these code changes directly. However, having a CDN with dedicated WAF will be a security benefit to customers.
Related to https://github.com/cloud-gov/private/issues/1098
Changes proposed in this pull request:
tests/integration/test_deprovision_common_checks.pyusing pytest parameterizationtests/lib/cdn/deprovision.pyThings to check
INFOand debugging statements are written withlog.debugor similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
There should be no security considerations to these code changes directly. However, having a CDN with dedicated WAF will be a security benefit to customers.