search

cloud-gov / kubernetes-broker

Broker for kubernetes based services
Apache License 2.0
5 stars 6 forks source link

[WIP] Build our own redis #52

Closed cnelson closed 7 years ago

cnelson commented 7 years ago

This is temporarily submoduling our current redis image until we decide what to use for sentinel support at which time we'll replace it with something more approproiate

rogeruiz commented 7 years ago

@cnelson I've been testing this in k8s-dev with this docker image. I haven't modified much, but I've forked it so I could test a few things out. wdyt about using that docker image rather than the one we currently use for our starting point?

cnelson commented 7 years ago

SGTM

cnelson commented 7 years ago

@rogeruiz can I close this PR? Do you have your own branch with updated redis changes on it?

rogeruiz commented 7 years ago

@cnelson Yeah, I think it makes sense to close this. We could also just keep this in for now. I ended up using a different version of Redis for HA so we have a whole set of Dockerfiles for that in redis-ha:customImages/redis32 (#55). Wdyt about upgrading all our Redis offerings to 3.x?

cnelson commented 7 years ago

I think it's a good idea but one that is totally not in scope for a story that's already late :)