cloud-gov / pages-core

cloud.gov Pages is a publishing platform for modern 21st Century IDEA websites.
https://cloud.gov/pages
Other
276 stars 68 forks source link

Add Build Containers Build to New Relic #1833

Closed amirbey closed 6 years ago

amirbey commented 6 years ago

User Story

Users should be able to build sites without backed up build queues due build container outage.

Background (Optional)

On 5/16 a build delay was reported and it was concluded that 5/6 build containers were down. The queue was backed up and it appeared that build were taking a long time to run.

Acceptance Criteria

After evaluating, edit this part:

Level of effort - <low/medium/high>

Low

Implementation outline (if higher than "low" effort):

amirbey commented 6 years ago

Accomplished using Federalist Builder Alerts in New Relic ... there ... the alert did not contain any recipients and this has been resolved

amirbey commented 6 years ago

Check instance state instead of app state

https://gsa-tts.slack.com/archives/C09CR1Q9Z/p1527099621000530

wslack commented 6 years ago

Ok - so we need to do more work in the app or in New Relic? I think our acceptance criteria is off now.

amirbey commented 6 years ago

I regressed this after talking to Adam Kendall. Federalist Builder's healthcheck makes encompasses the health of the builder. However, after talking to Adam it appears we are not doing the most accurate healthcheck possible. We are checking the app state when we should be checking the instance state. That should have given us an alert on the outage ~ 5/16

amirbey commented 6 years ago

I think the acceptance criteria is the same but it requires tweaking federalist builder healthcheck

wslack commented 6 years ago

On hold given other work.