cloud-gov / pages-core

cloud.gov Pages is a publishing platform for modern 21st Century IDEA websites.
https://cloud.gov/pages
Other
276 stars 68 forks source link

Fix Concourse builds by specifying Node minor version #4152

Closed svenaas closed 1 year ago

svenaas commented 1 year ago

Concourse builds on #4145 were failing with

node[1]: ../src/node_platform.cc:68:std::unique_ptr<long unsigned int> node::WorkerThreadsTaskRunner::DelayedTaskScheduler::Start(): Assertion `(0) == (uv_thread_create(t.get(), start_thread, this))' failed.

but were resolved by specifying Node image tag 18.15 instead of 18.

This may be the underlying issue, as it evidently rears up with .Ubuntu 22.04 (credit to @drewbo for finding this).

Acceptance Criteria

Security Considerations

This change specifies a more specific minor version consistent with what was previously being used for builds. Instead of getting a newer minor version of Node 18 we are pinned to a specific minor version, which is an important detail, but not a problem at this time.

drewbo commented 1 year ago

Closed via https://github.com/cloud-gov/pages-core/pull/4151