search

cloud-gov / pages-core

cloud.gov Pages is a publishing platform for modern 21st Century IDEA websites.
https://cloud.gov/pages
Other
276 stars 68 forks source link

Feat: allow suppression of rules from the reports page #4623

Closed sknep closed 2 weeks ago

sknep commented 1 month ago

Changes proposed in this pull request:

Adds report suppression information to each finding Allows the user to add or delete rules using the given rule id for each finding. Cleans up use of "scanType" now that we have sbt, which has an id and a type

security considerations

None

sknep commented 1 month ago

Do you think text-based is enough? i'm worried about an actual "toggle" button being distractingly visible at the top of each finding. Screenshot 2024-10-15 at 5 12 26 PM Screenshot 2024-10-15 at 5 12 03 PM

Screenshot 2024-10-15 at 5 12 21 PM Screenshot 2024-10-15 at 5 12 17 PM

apburnes commented 1 month ago

@sknep will you run make lint and fix the linting errors before we review?

apburnes commented 1 month ago

What's your thoughts on adding another toggle location at the top of the page in the violated rules list? Like 👇

Screenshot 2024-10-16 at 12 27 04 PM
sknep commented 1 month ago

hmm... I don't really want folks to be able to suppress without fully understanding the finding. Also that spot is already kind of busy/full, and keeping these reports scannable is important to me. But what do you think?