cloud-gov / product

Program-level artifacts, workflow and issues for cloud.gov
Creative Commons Zero v1.0 Universal
30 stars 15 forks source link

Tag SES resources with org, space tags #3107

Closed jameshochadel closed 6 days ago

jameshochadel commented 1 month ago

Other brokers tag resources using the https://github.com/cloud-gov/go-broker-tags repository. This broker should tag resources in the same way — e.g. CF org name, org GUID, space name, space GUID...

jameshochadel commented 2 weeks ago

Tagging with org and space information is currently not possible in the CSB. The CSB uses HIL to interpolate variables into service definition files. HIL does not support indexing into maps with heterogeneous value types, and the request.context map, which contains org and space information, contains both string and map types. I've opened a discussion in the CF Slack about possible workarounds.

OSBAPI Cloud Foundry Context object docs: https://github.com/openservicebrokerapi/servicebroker/blob/master/profile.md#cloud-foundry-context-object Discussion in CF Slack: https://cloudfoundry.slack.com/archives/C0164KKEZGX/p1724703876380109

jameshochadel commented 2 weeks ago

Started tagging all resources with default_tags on each provider. Now blocked until I hear back from the CSB dev team about the HIL issue.

jameshochadel commented 1 week ago

Submitted PR to fix the issue: https://github.com/cloudfoundry/cloud-service-broker/pull/1087

jameshochadel commented 6 days ago

Workaround works. Last tags added to broker; closing.