cloud-gov / s3-simple-resource

Concourse CI Resource for uploading files to S3
https://hub.docker.com/r/18fgsa/s3-resource-simple/
Other
30 stars 74 forks source link

Specifying working directory for aws sync command? #13

Open phillbaker opened 7 years ago

phillbaker commented 7 years ago

Since concourse puts are passed in the directory containing all of a plan's outputs, is it currently possible to sync only one output directory to the root of a s3 bucket?

It looks like we'd have to pass an additional parameter to either cd into or use in the aws sync line. Would you be open to that as a pull request?

Looks like someone tried something similar here: https://github.com/pivotal-sydney/s3-resource-simple/commit/3888817a6572c305ce0872c6bbe73868bbe51f99

gaelL commented 7 years ago

It would be great to have this feature. I'm using this resource and having the same need.

mcblair commented 7 years ago

@phillbaker Are you able to use pivotal-sydney's s3-resource-simple?

phillbaker commented 7 years ago

@mcblair my memory is a bit hazy, but I believe I did try to use their fork, and something didn't line up. We ended up forking and added the changes in #14.

mcblair commented 7 years ago

@phillbaker Same thing with me - their fork/docker image on docker hub wasn't savvy. Forked it and added the changes myself.

gaelL commented 6 years ago

This issue seems to be opened since 1y, and have several PR to fix it : like #14 and #21 and some people are forking specially because of this need (https://github.com/pivotal-sydney/s3-resource-simple/commit/3888817a6572c305ce0872c6bbe73868bbe51f99)

@afeld Is there anything we could do to help to fix that issue ?

Regards,