search

cloud-hypervisor / rust-hypervisor-firmware

Apache License 2.0
608 stars 57 forks source link

Remove Linux Boot Protocol Support #47

Closed josephlr closed 4 years ago

josephlr commented 4 years ago

Is this something that we want to keep around long-term?

Right now we only support this because CH used to require it, but now both CH and this firmware support PVH. Also, unlike PVH, our final binary doesn't advertise support for the Linux Boot Protocol (i.e. we don't have the right header+magic bits), so it seems strange that we implement it by blindly assuming that anything that uses the main 64-bit ELF entry point expects us to be Linux.

josephlr commented 4 years ago

The only reason I can think to keep it is for compatibility w/ firecracker or crosvm

rbradford commented 4 years ago

I think we can remove it.