search

cloud-native-go / examples

Apache License 2.0
329 stars 86 forks source link

Chapter 8 keyvalue.proto DeleteRequest returns PutResponse #9

Open adamwoolhether opened 2 years ago

adamwoolhether commented 2 years ago

https://github.com/cloud-native-go/examples/blob/8aafc16cb3dc857464275c488824de394bfb9e44/ch08/grpc/keyvalue/keyvalue.proto#L43

Shouldn't the DeleteRequest return a DeleteResponse? Seems correct in the book, or is it ok either way because both responses are an empty struct?

However, when looking at the generated keyvalue_grpc.pb.gofile on page 236 Delete does return a *PutResponse, aligned with the repo., so is this a typo in the book?

seabasssec commented 8 months ago

It seems to me that there is a typo in two places.