Closed luxas closed 5 years ago
Hi @luxas thanks for the continuous effort to improve the generator!
Can you explain the sponsorTier idea in a little more detail? I am unsure if this change adds complexity with little benefit but it is likely because I don't understand the reasons behind it. Could you give an example from the Helsinki area as to who would be in a certain tier and why it matters?
First of all, thanks @luxas! This looks great and follows the direction that we discussed. In regards to naming of the Meetup Sponsor, maybe event sponsor would be better?
@Steiniche We want to be able to highlight what the different sponsors has helped us with. A long-term sponsor, could be a hosting partner, or CNCF the continuously sponsor us with the meetup group and other stuff.
Meetup/Event sponsors as @luxas mentions is sponsors at a given meetup, e.g. venue, or food.
Speaker providers should be self-explanatory
And the last one for now is the Ecosystem sponsor which is basically, right now, just a list of companies that we know are working with these projects. They will not be provided a spot on the website.
With this, we should be able to distinguish the different sponsors on the website, sort them by their tiers etc.
@jepp2078 how does this look to you? From my perspective it looks good, but I'm not down in the nitty gritty details of the stats-api.
Looks good. I'll start aligning the stats-api now.
/lgtm
Let's merge this into meetup-kit-refactor
for now, then 👍
Thanks @jepp2078; I'll merge this PR now.
wrt the above, can you @kaspernissen and @Steiniche open a new issue to discuss the following?
Of course we can but I do not think it is needed. From the descption @kaspernissen gave I am fine with the changes.
This PR fixes some outstanding issues with
config.json
as discussed with @jepp2078, @kaspernissen and @netumoliver. This will make it easier for stats-api to read the config and generate a GraphQL-queryable database.Changes as follows:
sponsorTiers
map has been added toMeetupGroup
to tell what companies have been active in that city, on what level.@jepp2078 @kaspernissen does this look good? can we merge it to the generator refactor branch? When done, @jepp2078 can go ahead and modify stats-api accordingly to these changes.