gitops_repo_token is stored in wrong credentials.properties file

cloud-native-toolkit / iascable

IasCable is a node/typescript library to build installable component infrastructure components from a catalog of available modules

MIT License

13 stars 8 forks source link

gitops_repo_token is stored in wrong credentials.properties file #223

Open nheidloff opened 2 years ago

nheidloff commented 2 years ago

iascable --version 2.21.2

Sample:

https://github.ibm.com/isv-assets/watson-boms/blob/727b527351961f8058d566fecab7ab32942c1039/roks-new-nlp/bom.yaml#L25
https://github.ibm.com/isv-assets/watson-boms/blob/727b527351961f8058d566fecab7ab32942c1039/roks-new-nlp/output/credentials-template.properties#L1

gitops_repo_token is defined in output/credentials.properties. When running apply.sh, the value is stored in output/cluster-with-watson-nlp/credentials.properties

seansund commented 2 years ago

If gitops_repo_token (or any other value) is already available in an environment variable then it shouldn't write another copy into credentials.properties. I will fix that in the apply script