cloud-native-toolkit / multi-tenancy-gitops

Provides our opinionated point of view on how GitOps can be used to manage the infrastructure, services and application layers of K8s based systems
https://cloudnativetoolkit.dev/adopting/use-cases/gitops/gitops-ibm-cloud-paks/
Apache License 2.0
110 stars 730 forks source link

ArgoCD instance installed in a random namespace (NOT openshift-gitops) #282

Closed giovanni-savino closed 1 year ago

giovanni-savino commented 1 year ago

Dear team,

when deploying argocd instance, it does not have a namespace declared. ArgoCD is installed in a random namespace

eg

oc apply -f
../setup/ocp47/argocd-instance/argocd-instance.yaml
../setup/ocp4x/argocd-instance/argocd-instance.yaml
apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: openshift-gitops-cntk
spec:

Would it be better to declare it?

eg

apiVersion: argoproj.io/v1alpha1
kind: ArgoCD
metadata:
  name: openshift-gitops-cntk
  namespace: openshift-gitops
spec:
hollisc commented 1 year ago

In the Step 3 of this section in the README (https://github.com/cloud-native-toolkit/multi-tenancy-gitops#install-and-configure-openshift-gitops), the command will deploy the instance in the openshift-gitops namespace. We intentionally don't hardcode that in the yaml as one could install the instance in a different namespace or set up multiple instances of argocd.

oc apply -f setup/ocp47/argocd-instance/ -n openshift-gitops

Hope this helps.

giovanni-savino commented 1 year ago

Thanks