Open triceam opened 2 years ago
@triceam terraform-gitops-cp-db2-oltp is ready for review, I answered question around entitlement. As per the document and Cp4d team, global authentication is required for entitlement key in cp4d env, Please advise?
Error extracting values. See details at: https://github.com/cloud-native-toolkit/automation-modules/actions/runs/1991959395
@triceam The name of the module for provisioning db2(https://github.com/cloud-native-toolkit/terraform-gitops-cp-db2) was discussed and changed to cp-db2 in last week Tuesday's Office Hours call with everyone's consensus including you. Previously, it was created as db2 schema module. Hence, that description is there in README.md of main branch. I have updated it appropriately in my PR. I did discuss the review changes suggested by @seansund on a call with him yesterday. I have answered the questions raised by him and am working on incorporating changes.
@triceam Absolutely correct. This module will apply a schema to an already-created DB2 instance. As we discussed in Office Hours' call yesterday, I need a base image with DB2 cli for the job to work. I will create a PR and push the changes once I get the image. Testing would not be possible without that image.
Error extracting values. See details at: https://github.com/cloud-native-toolkit/automation-modules/actions/runs/1993499994
@triceam If you still would like to reconsider renaming db2 module(https://github.com/cloud-native-toolkit/terraform-gitops-cp-db2), I think we can discuss it again in the next Office Hours.
Error extracting values. See details at: https://github.com/cloud-native-toolkit/automation-modules/actions/runs/1993538001
Error extracting values. See details at: https://github.com/cloud-native-toolkit/automation-modules/actions/runs/1993600675
DB2 Modules have gotten a bit confusing. We need to make sure that the modules names and descriptions properly convey the module function. @yogendrasri @RamyaRaghuveera @balasgit can you confirm:
https://github.com/cloud-native-toolkit/terraform-gitops-db2u-operator This installs the DB2U operato subscription. I believe this is named correctly, and the PR has been reviewed/merged.
https://github.com/cloud-native-toolkit/terraform-gitops-cp-db2-oltp This version installs the Db2oltp operator and creates a
Db2oltpService
instance.terraform-gitops-cp-db2oltpService
?https://github.com/cloud-native-toolkit/terraform-gitops-cp-db2 This creates the DB2 Database instance. Right?
The description still says
Module tp populate a gitops repo with the resources to provision db2-schema
, which I believe is incorrect (and is different from the readme). Is this ready to review? I see @seansund has reviewed it, and there are both unanswered questions and suggested changes.This should probably be renamed to
terraform-gitops-cp-db2-instance
to make it clear that this provisions a database instance.https://github.com/cloud-native-toolkit/terraform-gitops-cp-db2-schema Once complete, this will apply a schema to an already-created DB2 instance. Correct? It looks like no changes have been committed to this one yet.