cloud-native-toolkit / software-everywhere

Automation modules to deploy IBM Software on IBM Cloud, AWS, and Azure
https://modules.cloudnativetoolkit.dev
Apache License 2.0
9 stars 9 forks source link

Db2 Module Naming & Description #25

Open triceam opened 2 years ago

triceam commented 2 years ago

DB2 Modules have gotten a bit confusing. We need to make sure that the modules names and descriptions properly convey the module function. @yogendrasri @RamyaRaghuveera @balasgit can you confirm:

yogendrasri commented 2 years ago

@triceam terraform-gitops-cp-db2-oltp is ready for review, I answered question around entitlement. As per the document and Cp4d team, global authentication is required for entitlement key in cp4d env, Please advise?

github-actions[bot] commented 2 years ago

Error extracting values. See details at: https://github.com/cloud-native-toolkit/automation-modules/actions/runs/1991959395

RamyaRaghuveera commented 2 years ago

@triceam The name of the module for provisioning db2(https://github.com/cloud-native-toolkit/terraform-gitops-cp-db2) was discussed and changed to cp-db2 in last week Tuesday's Office Hours call with everyone's consensus including you. Previously, it was created as db2 schema module. Hence, that description is there in README.md of main branch. I have updated it appropriately in my PR. I did discuss the review changes suggested by @seansund on a call with him yesterday. I have answered the questions raised by him and am working on incorporating changes.

RamyaRaghuveera commented 2 years ago

@triceam Absolutely correct. This module will apply a schema to an already-created DB2 instance. As we discussed in Office Hours' call yesterday, I need a base image with DB2 cli for the job to work. I will create a PR and push the changes once I get the image. Testing would not be possible without that image.

github-actions[bot] commented 2 years ago

Error extracting values. See details at: https://github.com/cloud-native-toolkit/automation-modules/actions/runs/1993499994

RamyaRaghuveera commented 2 years ago

@triceam If you still would like to reconsider renaming db2 module(https://github.com/cloud-native-toolkit/terraform-gitops-cp-db2), I think we can discuss it again in the next Office Hours.

github-actions[bot] commented 2 years ago

Error extracting values. See details at: https://github.com/cloud-native-toolkit/automation-modules/actions/runs/1993538001

github-actions[bot] commented 2 years ago

Error extracting values. See details at: https://github.com/cloud-native-toolkit/automation-modules/actions/runs/1993600675