Incorrect architecture igc binary is installed on ARM Mac.

cloud-native-toolkit / terraform-util-clis

Module to install missing clis into a local bin directory

Apache License 2.0

0 stars 3 forks source link

Incorrect architecture igc binary is installed on ARM Mac. #91

Closed binnes closed 2 years ago

binnes commented 2 years ago

script/setup-igc.sh script doesn't use the ARCH argument passed from setup-binary.sh, so on an M1 Mac the igc-macos binary is installed, which is the incorrect binary

Implementation note: Can't just use the arch argument, as need to sync up the script creating the igc binaries and this script, as the script uses ARCH amd64 for x86_64, but the binary is igc-macos-x64

timroster commented 2 years ago

URL built in scripts/setup-igc.sh needs to add the arch after the type:

"${SCRIPT_DIR}/setup-binary.sh" "${DEST_DIR}" "${CLI_NAME}" "https://github.com/cloud-native-toolkit/ibm-garage-cloud-cli/releases/download/${RELEASE}/igc-${TYPE}" --version