cloud-py-api / mediadc

Nextcloud Media Duplicate Collector application
https://apps.nextcloud.com/apps/mediadc
GNU Affero General Public License v3.0
95 stars 8 forks source link

Use Transifex for continuous translation please #71

Closed p-bo closed 2 years ago

p-bo commented 2 years ago

Hello, would it be possible to follow instructions on: https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#adding-translations ...and gain benefits from work of whole Nextcloud translators community for users of your app please?

For instance:

To conclude: with continuous translation workflow, result is, that users of your app are getting more complete and more polished localization, so their user experience is much more pleasant.

Thanks :-)

andrey18106 commented 2 years ago

@p-bo Added continuous translation, now it's available on Nextcloud Transifex Project.

p-bo commented 2 years ago

Many thanks @andrey18106 and @nickvergessen - appreciated! :-)

roliverio commented 2 years ago

Hi, would like to know if the string mappings currently under l10n/*.js should be expanded to effectively use the rest of strings that belong to the app (currently 224). Thanks.

nickvergessen commented 2 years ago

No, l10n/ is overwritten every night by the sync bot. If something is missing in the app the source code needs to be modified so that our translation tool can correctly extract it into the files that are then synced and turned into the l10n files afterwards

roliverio commented 2 years ago

Sorry, maybe my comment was not clear enough, i do know that the bot updates translations automatically, but my question was more geared towards knowing exactly what you're now saying, you'll need to modify the code to include the rest of the strings that are missing even if they're already on Transifex. Thanks! (working on them as we speak)

p-bo commented 2 years ago

@roliverio On Transifex are strings from newest revision of source code (head, main - formerly master), whereas as installed, you are using latest released version. Thus it should be, that strings, that were translated after release was done, are translated on Transifex, but not in time of current release (which is thus behind). Don't worry, just wait for newer release, which will have newest translations merged. If you want to test how strings fits, you can try night builds.

p-bo commented 2 years ago

@roliverio maybe understand now: obrazek It seems, that especially for admin settings, source strings are not extracted from source code by bot to Transifex at all (these strings are not present on Transifex, thus not in .js and .json files). Example of such strings: https://github.com/andrey18106/mediadc/search?q=Full+path+to+python+interpreter Probably is needed to add t('myapp', (into javascript code and analogically into php one) as stated in: https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#javascript