search

cloud-software-foundation / c5

c5
Apache License 2.0
12 stars 8 forks source link

Replicator cleanup #297

Closed joshua-g closed 10 years ago

joshua-g commented 10 years ago

This is a "miscellaneous" pull request with several relatively small changes. The two numbered issues it fixes are #246 and #262 -- cleaning up and simplifying the Replicator interface.

Also, FileChannel#force behavior is made enabled by default for the replicator log. It's now controlled from a static constant.

Several nits brought up from past code reviews are also addressed by commits herein.

posix4e commented 10 years ago

I feel like we still need to do some work. I removed my work, and some tests I can't get to pass consistently. Let's chat about it tomorrow. The code is a big improvement though

posix4e commented 10 years ago

I pushed a new branch to ohmdata/posix4e which does not have my mega merged patch but has this plus some changes. Tell me if i am being crazy

posix4e commented 10 years ago

I can certainly get QuorumDelegatingLogConcurrencyTest to fail localy.

joshua-g commented 10 years ago

QDLCT is fixed in a later commit (see https://github.com/joshua-g/c5/commit/3df8a86c60efcbfe9a99c5b0d8e796d7eb300b0a)