Add CLOUDABILITY_UPLOAD_REGION Env Variable - Githubissues

cloudability / metrics-agent

From the cloud optimization professionals

https://www.cloudability.com/

Apache License 2.0

39 stars 35 forks source link

Add CLOUDABILITY_UPLOAD_REGION Env Variable #233

Closed daniel-spray closed 1 year ago

daniel-spray commented 1 year ago

What does this PR do?

Adds a new environment variable CLOUDABILITY_UPLOAD_REGION Supported value:

us-west-2: Uploads to Apptio's US S3
Where should the reviewer start?

For context: There was two global variables for for the metrics collection endpoint in different packages. I removed one from a package and imported it to the other so we don't need to store duplicate global variables which could cause confusion.

How should this be manually tested?

Ran tests and deployed onto test cluster.

Any background context you want to provide?

Nope

What picture best describes this PR (optional but encouraged)?

What are the relevant Github Issues?

Developer Done List

[x] Tests Added/Updated
[x] Updated README.md
[x] Verified backward compatible
[x] Verified database migrations will not be catastrophic
[x] Considered Security, Availability and Confidentiality

For the Reviewer:

By approving this PR, the reviewer acknowledges that they have checked all items in this done list.

Reviewer/Approval Done List

[ ] Tests Pass Locally
[ ] CI Build Passes
[ ] Verified README.md is updated
[ ] Verified changes are backward compatible
[ ] Reviewed impact to Security, Availability and Confidentiality (if issue found, add comments and request changes)

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication